Re: [EXTERNAL] Re: [PATCH] net: phy: dp83867: perform soft reset and retain established link
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-03-31 16:36:38
Also in:
lkml
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-03-31 16:36:38
Also in:
lkml
> as per datasheet: https://www.ti.com/lit/ds/symlink/dp83867cr.pdf > 8.6.26 Control Register (CTRL) > do SW_RESTART to perform a reset not including the registers and is > acceptable to do this if a link is already present. I don't see any code here to determine if the like is present. What if the cable is not plugged in? This API is primarily used for reset. Link Status is checked thru different register. This shall not impact the cable plug in/out. With this change, it will align with DP83822 driver API.
So why is there the comment:
> and is
> acceptable to do this if a link is already present.That kind of says, it is not acceptable to do this if the link is not present. Which is why i'm asking. Andrew