Re: [PATCH v2 1/1] net: sched: bump refcount for new action in ACT replace mode
flat view
From: Cong Wang <hidden>
Date: 2021-03-31 04:41:45
Also in:
lkml
On Mon, Mar 29, 2021 at 3:55 PM Kumar Kartikeya Dwivedi [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/sched/act_api.c b/net/sched/act_api.c index b919826939e0..43cceb924976 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c@@ -1042,6 +1042,9 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp, if (err != ACT_P_CREATED) module_put(a_o->owner); + if (!bind && ovr && err == ACT_P_CREATED) + refcount_set(&a->tcfa_refcnt, 2); +
Hmm, if we set the refcnt to 2 here, how could tcf_action_destroy() destroy them when we rollback from a failure in the middle of the loop in tcf_action_init()? Thanks.