Re: [PATCH net-next 4/4] net: ipa: activate some commented assertions
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-03-19 18:33:34
Also in:
lkml
quoted hunk ↗ jump to hunk
@@ -212,7 +213,7 @@ static inline u32 ipa_reg_bcr_val(enum ipa_version version) BCR_HOLB_DROP_L2_IRQ_FMASK | BCR_DUAL_TX_FMASK; - /* assert(version != IPA_VERSION_4_5); */ + ipa_assert(NULL, version != IPA_VERSION_4_5);
Hi Alex
It is impossible to see just looking what the NULL means. And given
its the first parameter, it should be quite important. I find this API
pretty bad.
Andrew