Thread (25 messages) 25 messages, 6 authors, 2021-03-25

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-03-16 21:02:54
Also in: cgroups, linux-mm, lkml

On Mon, 15 Mar 2021 23:28:08 -0700 Arjun Roy wrote:
On Mon, Mar 15, 2021 at 11:22 PM Arjun Roy [off-list ref] wrote:
quoted
On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt [off-list ref] wrote:  
quoted
On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy [off-list ref] wrote:  
 [...]  
quoted
quoted
[...]  
 [...]  
 [...]  
quoted
quoted
It is due to "mm: page-writeback: simplify memcg handling in
test_clear_page_writeback()" patch in the mm tree. You would need to
reintroduce the lock_page_memcg() which returns the memcg and make
__unlock_page_memcg() non-static.  
To clarify, Shakeel - the tag "tag: v5.12-rc2-mmots-2021-03-11-21-49"
fails to build on a clean checkout, without this patch, due to a
compilation failure in mm/shmem.c, for reference:
https://pastebin.com/raw/12eSGdGD
(and that's why I'm basing this patch off of net-next in this email).

-Arjun  
Another seeming anomaly - the patch sent out passes
scripts/checkpatch.pl but netdev/checkpatch finds plenty of actionable
fixes here: https://patchwork.kernel.org/project/netdevbpf/patch/20210316041645.144249-1-arjunroy.kdev@gmail.com/

Is netdev using some other automated checker instead of scripts/checkpatch.pl?
--strict --max-line-length=80
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help