Thread (21 messages) 21 messages, 5 authors, 2021-03-10

Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT

From: Thomas Gleixner <hidden>
Date: 2021-03-10 08:36:11
Also in: linux-hyperv, linux-pci, linux-wireless, lkml

On Tue, Mar 09 2021 at 16:21, Sebastian Andrzej Siewior wrote:
On 2021-03-09 16:00:37 [+0100], To Thomas Gleixner wrote:
quoted
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 07c7329d21aa7..1c14ccd351091 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -663,15 +663,6 @@ static inline int tasklet_trylock(struct tasklet_struct *t)
 void tasklet_unlock(struct tasklet_struct *t);
 void tasklet_unlock_wait(struct tasklet_struct *t);
 
-/*
- * Do not use in new code. Waiting for tasklets from atomic contexts is
- * error prone and should be avoided.
- */
-static inline void tasklet_unlock_spin_wait(struct tasklet_struct *t)
-{
-	while (test_bit(TASKLET_STATE_RUN, &t->state))
-		cpu_relax();
-}
Look at that. The forward declaration for tasklet_unlock_spin_wait()
should have remained. Sorry for that.
No idea how I managed to mess that up and fail to notice. Brown
paperbags to the rescue.

Thanks,

        tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help