[patch 00/14] tasklets: Replace the spin wait loops and make it RT safe · Thomas Gleixner <hidden> · 2021-03-09
[patch 01/14] tasklets: Replace barrier() with cpu_relax() in tasklet_unlock_wait() · Thomas Gleixner <hidden> · 2021-03-09
[patch 02/14] tasklets: Use static inlines for stub implementations · Thomas Gleixner <hidden> · 2021-03-09
[patch 03/14] tasklets: Provide tasklet_disable_in_atomic() · Thomas Gleixner <hidden> · 2021-03-09
[patch 05/14] tasklets: Replace spin wait in tasklet_unlock_wait() · Thomas Gleixner <hidden> · 2021-03-09
[patch 06/14] tasklets: Replace spin wait in tasklet_kill() · Thomas Gleixner <hidden> · 2021-03-09
[patch 09/14] net: sundance: Use tasklet_disable_in_atomic(). · Thomas Gleixner <hidden> · 2021-03-09
[patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT · Thomas Gleixner <hidden> · 2021-03-09
Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT · Sebastian Andrzej Siewior <bigeasy@linutronix.de> · 2021-03-09
Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT · Sebastian Andrzej Siewior <bigeasy@linutronix.de> · 2021-03-09
Re: [patch 07/14] tasklets: Prevent tasklet_unlock_spin_wait() deadlock on RT · Thomas Gleixner <hidden> · 2021-03-10
[patch 08/14] net: jme: Replace link-change tasklet with work · Thomas Gleixner <hidden> · 2021-03-09
[patch 11/14] atm: eni: Use tasklet_disable_in_atomic() in the send() callback · Thomas Gleixner <hidden> · 2021-03-09
[patch 13/14] firewire: ohci: Use tasklet_disable_in_atomic() where required · Thomas Gleixner <hidden> · 2021-03-09
[patch 12/14] PCI: hv: Use tasklet_disable_in_atomic() · Thomas Gleixner <hidden> · 2021-03-09
Re: [patch 12/14] PCI: hv: Use tasklet_disable_in_atomic() · Bjorn Helgaas <helgaas@kernel.org> · 2021-03-09
Re: [patch 12/14] PCI: hv: Use tasklet_disable_in_atomic() · Wei Liu <wei.liu@kernel.org> · 2021-03-10
[patch 10/14] ath9k: Use tasklet_disable_in_atomic() · Thomas Gleixner <hidden> · 2021-03-09
[patch 14/14] tasklets: Switch tasklet_disable() to the sleep wait variant · Thomas Gleixner <hidden> · 2021-03-09
[patch 04/14] tasklets: Use spin wait in tasklet_disable() temporarily · Thomas Gleixner <hidden> · 2021-03-09
Re: [patch 00/14] tasklets: Replace the spin wait loops and make it RT safe · Peter Zijlstra <peterz@infradead.org> · 2021-03-09

Re: [patch 00/14] tasklets: Replace the spin wait loops and make it RT safe

From: Peter Zijlstra <peterz@infradead.org>
Date: 2021-03-09 14:06:13
Also in: linux-hyperv, linux-pci, linux-wireless, lkml

On Tue, Mar 09, 2021 at 09:42:03AM +0100, Thomas Gleixner wrote:

This is a follow up to the review comments of the series which makes
softirq processing PREEMPT_RT safe:

 https://lore.kernel.org/r/20201207114743.GK3040@hirez.programming.kicks-ass.net (local)

Peter suggested to replace the spin waiting in tasklet_disable() and
tasklet_kill() with wait_event(). This also gets rid of the ill defined
sched_yield() in tasklet_kill().

Analyzing all usage sites of tasklet_disable() and tasklet_unlock_wait() we
found that most of them are safe to be converted to a sleeping wait.

Only a few instances invoke tasklet_disable() from atomic context. A few
bugs which have been found in course of this analysis have been already
addressed seperately.

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help