On Mon, Mar 08, 2021 at 04:57:35PM +0200, Andy Shevchenko wrote:

On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson
[off-list ref] wrote:

quoted

On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote:

quoted

On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
[off-list ref] wrote:

quoted

quoted

quoted

Define acpi_mdiobus_register() to Register mii_bus and create PHYs for
each ACPI child node.

quoted

+#include <linux/acpi.h>
+#include <linux/acpi_mdio.h>

Perhaps it's better to provide the headers that this file is direct
user of, i.e.
 bits.h
 dev_printk.h

Looks like device.h needs to be used instead of dev_printk.h. Please
let me know if you've a different opinion.

I don't see the user of device.h. dev_printk.h is definitely in use here...
Do you see a user for device.h? Which line in your code requires it?

It might be that I don't see something quite obvious...

I thought of including device.h instead of dev_printk.h because, it is the
only file that includes dev_printk.h and device.h is widely used. Of course,
it will mean that dev_printk.h is indirectly called.

Regards
Calvin