Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote:

On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
[off-list ref] wrote:

quoted

Define acpi_mdiobus_register() to Register mii_bus and create PHYs for
each ACPI child node.

quoted

+#include <linux/acpi.h>
+#include <linux/acpi_mdio.h>

Perhaps it's better to provide the headers that this file is direct
user of, i.e.
 bits.h
 dev_printk.h

Looks like device.h needs to be used instead of dev_printk.h. Please
let me know if you've a different opinion.

 module.h
 types.h

The rest seems fine because they are guaranteed to be included by
acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs).

Thanks
Calvin