Re: [PATCH wpan 04/17] net: ieee802154: forbid monitor for set llsec params
From: Stefan Schmidt <stefan@datenfreihafen.org>
Date: 2021-03-03 04:23:58
Hello Alex. On 28.02.21 16:18, Alexander Aring wrote:
quoted hunk ↗ jump to hunk
This patch forbids to set llsec params for monitor interfaces which we don't support yet. Reported-by: syzbot+8b6719da8a04beeafcc3@syzkaller.appspotmail.com Signed-off-by: Alexander Aring <aahringo@redhat.com> --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+)diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index 3ee09f6d13b7..67f0dc622bc2 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c@@ -1384,6 +1384,9 @@ static int nl802154_set_llsec_params(struct sk_buff *skb, u32 changed = 0; int ret; + if (wpan_dev->iftype == NL802154_IFTYPE_MONITOR) + return -EOPNOTSUPP; + if (info->attrs[NL802154_ATTR_SEC_ENABLED]) { u8 enabled;
I am fine with this patch and all the rest up to 17. They just do not apply for me with 1 and 2 left out and only 3 applied. Could you resend 3-17 as a series and we can discuss 1 & 2 separately? regards Stefan Schmidt