Thread (25 messages) flat view 25 messages, 3 authors, 2021-03-06

Re: [PATCH wpan 02/17] net: ieee802154: fix memory leak when deliver monitor skbs

From: Alexander Aring <alex.aring@gmail.com>
Date: 2021-03-01 03:17:35

Hi Stefan,

On Sun, 28 Feb 2021 at 10:21, Alexander Aring [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch adds a missing consume_skb() when deliver a skb to upper
monitor interfaces of a wpan phy.

Reported-by: syzbot+44b651863a17760a893b@syzkaller.appspotmail.com
Signed-off-by: Alexander Aring <aahringo@redhat.com>
---
 net/mac802154/rx.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
index b8ce84618a55..18abc1f49323 100644
--- a/net/mac802154/rx.c
+++ b/net/mac802154/rx.c
@@ -244,6 +244,8 @@ ieee802154_monitors_rx(struct ieee802154_local *local, struct sk_buff *skb)
                        sdata->dev->stats.rx_bytes += skb->len;
                }
        }
+
+       consume_skb(skb);
Please drop this patch. It's not correct. I will look next weekend at
this one again.
The other patches should be fine, I hope.

- Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help