Re: [Patch bpf-next v4 4/5] skmsg: move sk_redir from TCP_SKB_CB to skb
From: Cong Wang <hidden>
Date: 2021-02-17 18:51:12
Also in:
bpf
From: Cong Wang <hidden>
Date: 2021-02-17 18:51:12
Also in:
bpf
On Wed, Feb 17, 2021 at 10:40 AM John Fastabend [off-list ref] wrote:
quoted
@@ -802,9 +809,10 @@ int sk_psock_tls_strp_read(struct sk_psock *psock, struct sk_buff *skb) * TLS context. */ skb->sk = psock->sk; - tcp_skb_bpf_redirect_clear(skb); + skb_dst_drop(skb); + skb_bpf_redirect_clear(skb);Do we really need the skb_dst_drop() I thought we would have already dropped this here but I've not had time to check yet.
Yes, I got some serious complaints from dst_release() when I didn't add skb_dst_drop(). Thanks.