Thread (14 messages) flat view 14 messages, 3 authors, 2021-02-13

Re: [PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

From: Sven Van Asbroeck <hidden>
Date: 2021-02-12 22:48:38
Also in: lkml

Hi Bryan,

On Fri, Feb 12, 2021 at 3:45 PM [off-list ref] wrote:
According to the document I have, FRAME_LENGTH is only valid when LS bit is set, and reserved otherwise.
Therefore, I'm not sure you can rely on it being zero when LS is not set, even if your experiments say it is.
Future chip revisions might use those bits differently.
That's good to know. I didn't find any documentation related to
multi-buffer frames, so I had to go with what I saw the chip do
experimentally. It's great that you were able to double-check against
the official docs.
Can you change this so the LS bit is checked.
        If set you can use the smaller of FRAME_LENGTH or buffer length.
        If clear you can just use buffer length.
Will do. Are you planning to hold off your tests until v3? It
shouldn't take too long.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help