Thread (22 messages) 22 messages, 5 authors, 2021-02-13

Re: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-02-12 18:08:17
Also in: bridge, linux-omap, lkml


On 2/12/2021 7:15 AM, Vladimir Oltean wrote:
From: Vladimir Oltean <vladimir.oltean@nxp.com>

For the netlink interface, propagate errors through extack rather than
simply printing them to the console. For the sysfs interface, we still
print to the console, but at least that's one layer higher than in
switchdev, which also allows us to silently ignore the offloading of
flags if that is ever needed in the future.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

I suppose the slight "loss" of information on which port failed the
operation is okay since it was implied by either the path (sysfs) or the
bridge command.
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help