Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-02-12 18:06:38
Also in:
bridge, linux-omap, lkml
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-02-12 18:06:38
Also in:
bridge, linux-omap, lkml
On 2/12/2021 7:15 AM, Vladimir Oltean wrote:
From: Vladimir Oltean <vladimir.oltean@nxp.com> If for example this command: ip link set swp0 type bridge_slave flood off mcast_flood off learning off succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at BR_LEARNING, there would be no attempt to revert the partial state in any way. Arguably, if the user changes more than one flag through the same netlink command, this one _should_ be all or nothing, which means it should be passed through switchdev as all or nothing. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian