Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-02-12 15:24:42
Also in:
lkml
On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote:
+static u32 vsc85xx_csr_read(struct phy_device *phydev, + enum csr_target target, u32 reg); +static int vsc85xx_csr_write(struct phy_device *phydev, + enum csr_target target, u32 reg, u32 val); +
Hi Bjarni No forward definitions please. Move the code around so they are not required. Sometimes it is best to do such a move as a preparation patch.
quoted hunk ↗ jump to hunk
@@ -1569,8 +1664,16 @@ static int vsc8514_config_pre_init(struct phy_device *phydev) {0x16b2, 0x00007000}, {0x16b4, 0x00000814}, }; + struct device *dev = &phydev->mdio.dev; unsigned int i; u16 reg; + int ret;
Hard to say from the limited context, but is reverse christmass tree
being preserved here?
Andrew