RE: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case
From: Paul Durrant <hidden>
Date: 2021-02-11 14:26:00
Also in:
lkml, xen-devel
From: Paul Durrant <hidden>
Date: 2021-02-11 14:26:00
Also in:
lkml, xen-devel
-----Original Message----- From: Juergen Gross <jgross@suse.com> Sent: 11 February 2021 10:16 To: xen-devel@lists.xenproject.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Juergen Gross <jgross@suse.com>; Wei Liu <wei.liu@kernel.org>; Paul Durrant <paul@xen.org>; David S. Miller [off-list ref]; Jakub Kicinski [off-list ref] Subject: [PATCH v2 4/8] xen/netback: fix spurious event detection for common event case In case of a common event for rx and tx queue the event should be regarded to be spurious if no rx and no tx requests are pending. Unfortunately the condition for testing that is wrong causing to decide a event being spurious if no rx OR no tx requests are pending. Fix that plus using local variables for rx/tx pending indicators in order to split function calls and if condition.
Definitely neater.
Fixes: 23025393dbeb3b ("xen/netback: use lateeoi irq binding")
Signed-off-by: Juergen Gross <jgross@suse.com>Reviewed-by: Paul Durrant <paul@xen.org>