Re: [PATCH v3 net-next 10/11] net: mscc: ocelot: offload bridge port flags to device
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-02-11 04:22:05
Also in:
bridge, linux-omap, lkml
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-02-11 04:22:05
Also in:
bridge, linux-omap, lkml
On 2/10/2021 1:14 AM, Vladimir Oltean wrote:
From: Vladimir Oltean <vladimir.oltean@nxp.com> We should not be unconditionally enabling address learning, since doing that is actively detrimential when a port is standalone and not offloading a bridge. Namely, if a port in the switch is standalone and others are offloading the bridge, then we could enter a situation where we learn an address towards the standalone port, but the bridged ports could not forward the packet there, because the CPU is the only path between the standalone and the bridged ports. The solution of course is to not enable address learning unless the bridge asks for it. We need to set up the initial port flags for no learning and flooding everything, then the bridge takes over. The flood configuration was already configured ok in ocelot_init, we just need to disable learning in ocelot_init_port. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian