Re: [PATCH net-next 7/9] net: phy: icplus: select page before writing control register

Am 2021-02-10 11:30, schrieb Russell King - ARM Linux admin:

On Wed, Feb 10, 2021 at 08:03:07AM +0100, Heiner Kallweit wrote:

quoted

On 09.02.2021 17:40, Michael Walle wrote:

quoted

+out:
+	return phy_restore_page(phydev, oldpage, err);

If a random page was set before entering config_init, do we actually 
want
to restore it? Or wouldn't it be better to set the default page as 
part
of initialization?

I think you've missed asking one key question: does the paging on this
PHY affect the standardised registers at 0..15 inclusive, or does it
only affect registers 16..31?

For this PHY it affects only registers >=16. But that doesn't invaldiate
the point that for other PHYs this might affect all regsisters. Eg. ones
where you could select between fiber and copper pages, right?

If it doesn't affect the standardised registers, then the genphy_*
functions don't care which page is selected.

-- 
-michael