Re: [PATCH net-next 7/9] net: phy: icplus: select page before writing control register

On Wed, Feb 10, 2021 at 08:03:07AM +0100, Heiner Kallweit wrote:

On 09.02.2021 17:40, Michael Walle wrote:

quoted

+out:
+	return phy_restore_page(phydev, oldpage, err);

If a random page was set before entering config_init, do we actually want
to restore it? Or wouldn't it be better to set the default page as part
of initialization?

I think you've missed asking one key question: does the paging on this
PHY affect the standardised registers at 0..15 inclusive, or does it
only affect registers 16..31?

If it doesn't affect the standardised registers, then the genphy_*
functions don't care which page is selected.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!