Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

On Thu, Feb 25, 2021 at 11:29:42AM +0000, Russell King - ARM Linux admin wrote:

On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote:

quoted

 static void enetc_pl_mac_link_up(struct phylink_config *config,
 				 struct phy_device *phy, unsigned int mode,
 				 phy_interface_t interface, int speed,

@@ -945,6 +981,10 @@ static void enetc_pl_mac_link_up(struct phylink_config *config,
 		enetc_sched_speed_set(priv, speed);
 
 	enetc_mac_enable(&pf->si->hw, true);
+
+	if (!phylink_autoneg_inband(mode) &&
+	    phy_interface_mode_is_rgmii(interface))
+		enetc_force_rgmii_mac(&pf->si->hw, speed, duplex);

Does it matter that you're forcing the RGMII setup after having enabled
the MAC?

Thanks, this is a good point. I had tested only at gigabit on the
LS1028A-QDS, but at 10/100 things seem to be broken if I update the
speed with the MAC being enabled. I'll send a v2 with this change and
also with a build failure fix for patch 4/6.