Re: [PATCH net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2021-02-25 11:32:16
On Thu, Feb 25, 2021 at 01:23:57PM +0200, Vladimir Oltean wrote:
quoted hunk ↗ jump to hunk
static void enetc_pl_mac_link_up(struct phylink_config *config, struct phy_device *phy, unsigned int mode, phy_interface_t interface, int speed,@@ -945,6 +981,10 @@ static void enetc_pl_mac_link_up(struct phylink_config *config, enetc_sched_speed_set(priv, speed); enetc_mac_enable(&pf->si->hw, true); + + if (!phylink_autoneg_inband(mode) && + phy_interface_mode_is_rgmii(interface)) + enetc_force_rgmii_mac(&pf->si->hw, speed, duplex);
Does it matter that you're forcing the RGMII setup after having enabled the MAC? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!