RE: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for gmac driver

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: 2021年2月24日 0:46
To: Joakim Zhang <redacted>
Cc: peppe.cavallaro@st.com; alexandre.torgue@st.com;
joabreu@synopsys.com; davem@davemloft.net; netdev@vger.kernel.org;
dl-linux-imx [off-list ref]
Subject: Re: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for
gmac driver

On Tue, 23 Feb 2021 18:48:16 +0800 Joakim Zhang wrote:

quoted

+static int stmmac_bus_clks_enable(struct stmmac_priv *priv, bool
+enabled)

nit: my personal preference is to not call functions .._enable() and then make
them have a parameter saying if it's enable or disable.
Call the function .._config() or .._set() or such.

OK, thanks, will improve it.

Best Regards,
Joakim Zhang