Re: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for gmac driver
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-02-23 16:47:09
On Tue, 23 Feb 2021 18:48:16 +0800 Joakim Zhang wrote:
+static int stmmac_bus_clks_enable(struct stmmac_priv *priv, bool enabled)
nit: my personal preference is to not call functions .._enable() and then make them have a parameter saying if it's enable or disable. Call the function .._config() or .._set() or such.