Re: [PATCH v2 net-next] net: phy: icplus: call phy_restore_page() when phy_select_page() fails
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2021-02-19 11:38:15
Also in:
kernel-janitors
On Fri, Feb 19, 2021 at 01:10:44PM +0300, Dan Carpenter wrote:
The comments to phy_select_page() say that "phy_restore_page() must
always be called after this, irrespective of success or failure of this
call." If we don't call phy_restore_page() then we are still holding
the phy_lock_mdio_bus() so it eventually leads to a dead lock.
Fixes: 32ab60e53920 ("net: phy: icplus: add MDI/MDIX support for IP101A/G")
Fixes: f9bc51e6cce2 ("net: phy: icplus: fix paged register access")
Signed-off-by: Dan Carpenter <redacted>Reviewed-by: Russell King <redacted> Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!