Re: [PATCH] net: tracepoint: exposing sk_family in all tcp:tracepoints
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-02-03 18:18:01
On Wed, 3 Feb 2021 08:26:04 -0800 sdf@google.com wrote:
On 02/02, Eric Dumazet wrote:quoted
On Mon, Feb 1, 2021 at 11:06 PM Jakub Kicinski [off-list ref] wrote:quoted
Eric, any thoughts?quoted
I do not use these tracepoints in production scripts, but I wonder if existing tools could break after this change ?quoted
Or do we consider tracepoints format is not part of the ABI and can be arbitrarily changed by anyone ?They are not ABI and since we are extending tracepoints with additional info (and not removing any existing fields) it shouldn't be a problem.
Okay, but we should perhaps add the field at the end just to be on the safe side (and avoid weird alignment of the IP addresses).