Re: [PATCH] net: tracepoint: exposing sk_family in all tcp:tracepoints
From: <hidden>
Date: 2021-02-03 16:26:52
On 02/02, Eric Dumazet wrote:
On Mon, Feb 1, 2021 at 11:06 PM Jakub Kicinski [off-list ref] wrote:quoted
On Fri, 29 Jan 2021 00:12:10 +0000 Hariharan Ananthakrishnan wrote:quoted
Similar to sock:inet_sock_set_state tracepoint, expose sk_family to distinguish AF_INET and AF_INET6 families. The following tcp tracepoints are updated: tcp:tcp_destroy_sock tcp:tcp_rcv_space_adjust tcp:tcp_retransmit_skb tcp:tcp_send_reset tcp:tcp_receive_reset tcp:tcp_retransmit_synack tcp:tcp_probe Signed-off-by: Hariharan Ananthakrishnan <redacted> Signed-off-by: Brendan Gregg <redacted>Eric, any thoughts?
I do not use these tracepoints in production scripts, but I wonder if existing tools could break after this change ?
Or do we consider tracepoints format is not part of the ABI and can be arbitrarily changed by anyone ?
They are not ABI and since we are extending tracepoints with additional info (and not removing any existing fields) it shouldn't be a problem.