Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

From
Jakub Kicinski <kuba@kernel.org>
Date
2021-01-23 02:15:59
Also in
linux-arm-kernel, lkml
Reply to
Richard Cochran, 2021-01-21
On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote:
On Thu, Jan 21, 2021 at 10:27:54AM +0000, Russell King - ARM Linux admin wrote:
quoted
On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote:  
quoted
The mvpp2 is an Ethernet driver, and it implements MAC style time
stamping of PTP frames.  It has no need of the expensive option to
enable PHY time stamping.  Remove the incorrect dependency.

Signed-off-by: Richard Cochran <richardcochran@gmail.com>
Fixes: 91dd71950bd7 ("net: mvpp2: ptp: add TAI support")  
NAK.  
Can you please explain why mvpp2 requires NETWORK_PHY_TIMESTAMING?
Russell, I think we all agree now this is not the solution to the
problem of which entity should provide the timestamp, but the series
doesn't seem objectionable in itself.

Please LMK if you think otherwise.

(I would put it in net-next tho, given the above this at most a space
optimization.)
Thread (15 messages) 15 messages, 4 authors, last reply 2021-01-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help