On Fri, Jan 22, 2021 at 05:40:41PM +0100, Rafael J. Wysocki wrote:

On Fri, Jan 22, 2021 at 4:46 PM Calvin Johnson
[off-list ref] wrote:

quoted

Using fwnode_get_id(), get the reg property value for DT node
or get the _ADR object value for ACPI node.

So I'm not really sure if this is going to be generically useful.

First of all, the meaning of the _ADR return value is specific to a
given bus type (e.g. the PCI encoding of it is different from the I2C
encoding of it) and it just happens to be matching the definition of
the "reg" property for this particular binding.

IOW, not everyone may expect the "reg" property and the _ADR return
value to have the same encoding and belong to the same set of values,

I have counted three or even four attempts to open code exact this scenario
in the past couple of years. And I have no idea where to put a common base for
them so they will not duplicate this in each case.

so maybe put this function somewhere closer to the code that's going
to use it, because it seems to be kind of specific to this particular
use case?

-- 
With Best Regards,
Andy Shevchenko