Re: [EXT] Re: [PATCH RFC net-next 14/19] net: mvpp2: add ethtool flow control configuration support

From
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date
2021-01-10 18:34:32
Also in
lkml
Reply to
Stefan Chulski, 2021-01-10
On Sun, Jan 10, 2021 at 06:27:57PM +0000, Stefan Chulski wrote:
quoted
What also concerns me is whether flow control is supported in the existing
driver at all, given this patch set. If it isn't supported without the firmware's
help, then we should _not_ be negotiating flow control with the link partner
unless we actually support it, so the Pause and Asym_Pause bits in
mvpp2_phylink_validate() should be cleared.
RX FC supported, issue only with TX FC.
That doesn't seem relevant given table 28B in IEEE 802.3. There is
no advertisement combination that allows one to advertise an ability
to receive FC frames but not transmit FC frames.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Thread (48 messages) 48 messages, 3 authors, last reply 2021-01-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help