quoted
quoted
quoted
+ } else {
+ priv->sram_pool = of_gen_pool_get(dn, "cm3-mem", 0);
+ if (!priv->sram_pool) {
+ dev_warn(&pdev->dev, "DT is too old, TX FC
disabled\n");
I don't see anything in this patch that disables TX flow control,
which means this warning message is misleading.
OK, I would change to TX FC not supported.
And you should tell phlylink, so it knows to disable it in autoneg.
Which make me wonder, do we need a fix for stable? Has flow control never
been support in this device up until these patches get merged?
It should not be negotiated if it is not supported, which means telling phylink.
Andrew
TX FC never were really supported. MAC or PHY can negotiated flow control.
But MAC would never trigger FC frame.
Should I prepare separate patch that disable TX FC till we merge this patches?
Regards,
Stefan.