Re: [PATCH v2 net-next 0/2] net: dsa: mv88e6xxx: LAG fixes

On Sat, 16 Jan 2021 01:55:47 +0200 Vladimir Oltean wrote:

On Fri, Jan 15, 2021 at 03:46:22PM -0800, Jakub Kicinski wrote:

quoted

On Sat, 16 Jan 2021 01:24:35 +0200 Vladimir Oltean wrote:  

quoted

On Fri, Jan 15, 2021 at 03:02:46PM -0800, Jakub Kicinski wrote:  

quoted

On Fri, 15 Jan 2021 13:52:57 +0100 Tobias Waldekranz wrote:  

quoted

The kernel test robot kindly pointed out that Global 2 support in
mv88e6xxx is optional.

This also made me realize that we should verify that the hardware
actually supports LAG offloading before trying to configure it.

v1 -> v2:
- Do not allocate LAG ID mappings on unsupported hardware (Vladimir).
- Simplify _has_lag predicate (Vladimir).  

If I'm reading the discussion on v1 right there will be a v3,
LMK if I got it wrong.  

I don't think a v3 was supposed to be coming, what made you think that?  

I thought you concluded that the entire CONFIG_NET_DSA_MV88E6XXX_GLOBAL2
should go, you said:
 

quoted

So, roughly, you save 10%/13k. That hardly justifies the complexity IMO.  

That would be the first time that I hear of fixing a build failure due
to a missing shim by refactoring a driver... Punctual issue, punctual
fix, no?

Sure, without knowing the driver it's hard to tell if it's a matter of
removing those stubs in the header, or more work, hence the question. 

Applied now, thanks!