Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY

On Tue, Jan 12, 2021 at 11:28:00PM +0100, Marek Vasut wrote:

On 1/11/21 3:47 PM, Andrew Lunn wrote:

quoted

On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:

quoted

Unless the internal PHY is connected and started, the phylib will not
poll the PHY for state and produce state updates. Connect the PHY and
start/stop it.

Hi Marek

Please continue the conversion and remove all mii_calls.

ks8851_set_link_ksettings() calling mii_ethtool_set_link_ksettings()
is not good, phylib will not know about changes which we made to the
PHY etc.

Hi,

I noticed a couple of drivers implement both the mii and mdiobus options.

Which ones?

Simply getting the link status might be safe, but if
set_link_ksettings() or get_link_ksettings() is used, phylib is going
to get confused when the PHY is changed without it knowing.. So please
do remove all the mii calls as part of the patchset.

	Andrew