Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY
From: Marek Vasut <marex@denx.de>
Date: 2021-01-12 22:29:46
On 1/11/21 3:43 PM, Heiner Kallweit wrote:
On 11.01.2021 15:10, Marek Vasut wrote:quoted
On 1/11/21 2:50 PM, Heiner Kallweit wrote:quoted
On 11.01.2021 14:38, Marek Vasut wrote:quoted
On 1/11/21 2:26 PM, Heiner Kallweit wrote: [...]quoted
LGTM. When having a brief look at the driver I stumbled across two things: 1. Do MAC/PHY support any pause mode? Then a call to phy_support_(a)sym_pause() would be missing.https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8851-16MLL-Single-Port-Ethernet-MAC-Controller-with-8-Bit-or-16-Bit-Non-PCI-Interface-DS00002357B.pdf page 64 https://www.mouser.com/datasheet/2/268/ksz8851-16mll_ds-776208.pdf page 65 The later is more complete. Apparently it does support pause.Based on the datasheet, does it support sym or asym pause ?According to the description of flow control on p.23 it can support asym pause. However on the MAC side flow control doesn't seem to be always active, it's controlled by these two bits: p.49, TXCR, bit 3 p.50, RXCR1, bit 10 Default seems to be that flow control is disabled.
So I guess this patch is OK as-is ?