Re: [PATCH 2/7] ibmvnic: update reset function prototypes

Jakub Kicinski [kuba@kernel.org] wrote:

On Sun, 10 Jan 2021 19:12:21 -0800 Sukadev Bhattiprolu wrote:

quoted

Jakub Kicinski [kuba@kernel.org] wrote:

quoted

On Thu,  7 Jan 2021 23:12:31 -0800 Sukadev Bhattiprolu wrote:  

quoted

The reset functions need just the 'reset reason' parameter and not
the ibmvnic_rwi list element. Update the functions so we can simplify
the handling of the ->rwi_list in a follow-on patch.

Fixes: 2770a7984db5 ("ibmvnic: Introduce hard reset recovery")
  

No empty lines after Fixes tags, please. They should also not be
wrapped.  

Ah ok, will fix.

quoted

quoted

Signed-off-by: Sukadev Bhattiprolu <redacted>  

Are these patches for net or net-next? It looks like they are fixing
races, but at the same time they are rather large. Can you please
produce minimal fixes, e.g. patch 3 should just fix the existing leaks
rather than refactor the code to not do allocations. 130+ LoC is a lot
for a fix.  

This is a set of bug fixes, but yes a bit large. Should I submit to
net-next instead?

I'd rather you tried to address the problems with minimal patches, then
you can refactor the code in net-next.

I had thought about that but fixing the leaks and then throwing away the
code did not seem very useful. The diff stat shows 78 insertions and 59
deletions. The bulk of the new code, about 70 lines including comments,
is just the fairly straightforward helper functions:

	- get_pending_reset()
	- add_pending_reset() 

Fixing the leak in the existing code would not reduce the size of these
helpers. We are now using a simpler approach with no allocations, so no
leaks.

Sukadev