Re: [PATCH net 6/9] MAINTAINERS: mtk-eth: remove Felix

On Mon, 2021-01-11 at 09:41 -0800, Jakub Kicinski wrote:

On Sun, 10 Jan 2021 21:45:46 -0800 Joe Perches wrote:

quoted

On Sun, 2021-01-10 at 21:27 -0800, Jakub Kicinski wrote:

quoted

Drop Felix from Mediatek Ethernet driver maintainers.
We haven't seen any tags since the initial submission.  

[]

quoted

diff --git a/MAINTAINERS b/MAINTAINERS  

[]

quoted

@@ -11165,7 +11165,6 @@ F:	Documentation/devicetree/bindings/dma/mtk-*

 F:	drivers/dma/mediatek/
 

 MEDIATEK ETHERNET DRIVER
-M:	Felix Fietkau [off-list ref]
 M:	John Crispin [off-list ref]
 M:	Sean Wang [off-list ref]
 M:	Mark Lee [off-list ref]  

I think your script is broken as there are multiple subdirectories
for this entry and 

Quite the opposite, the script intentionally only counts contributions
only to the code under the MAINTAINERS entry.

My mistake.  I'd seen Felix's name fairly often.

I ran this command:

$ git log --pretty=oneline --since=5-years-ago --grep="-by: Felix Fietkau" drivers/net/ethernet/mediatek/
656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet

Saw that felix had worked on mediatek and then looked up files in
drivers/net with mediatek and conflated the wireless files and ethernet files.

btw: because I didn't see the script published and so can't verify what's
being done here, the MAINTAINERS file shows:

	F: *Files* and directories wildcard patterns.
	   A trailing slash includes all files and subdirectory files.
	   F:	drivers/net/	all files in and below drivers/net
	   F:	drivers/net/*	all files in drivers/net, but not below

cheers, Joe