From: Jakub Kicinski <kuba@kernel.org> Date: 2021-01-11 05:29:00
Hi!
This series intends to remove some most evidently inactive maintainers.
To make maintainers' lives easier we're trying to nudge people
towards CCing all the relevant folks on patches, in an attempt
to improve review rate. We have a check in patchwork which validates
the CC list against get_maintainers.pl. It's a little awkward, however,
to force people to CC maintainers who we haven't seen on the mailing
list for years. This series removes from maintainers folks who didn't
provide any tag (incl. authoring a patch) in the last 5 years.
To ensure reasonable signal to noise ratio we only considered
MAINTAINERS entries which had more than 100 patches fall under
them in that time period.
All this is purely a process-greasing exercise, I hope nobody
sees this series as an affront. Most folks are moved to CREDITS,
a couple entries are simply removed.
The following inactive maintainers are kept, because they indicated
the intention to come back in the near future:
- Veaceslav Falico (bonding)
- Christian Benvenuti (Cisco drivers)
Patches in this series contain report from a script which did
the analysis. Big thanks to Jonathan Corbet for help and writing
the script (although I feel like I used it differently than Jon
may have intended ;)). The output format is thus:
Subsystem $name
Changes $reviewed / $total ($percent%) // how many changes to the subsystem had at least one ack/review
Last activity: $date_of_most_recent_patch
$maintainer/reviewer1:
Author $last_commit_authored_by_the_person $how_many_in_5yrs
Committer $last_committed $how_many
Tags $last_tag_like_review_signoff_etc $how_many
$maintainer/reviewer2:
Author $last_commit_authored_by_the_person $how_many_in_5yrs
Committer $last_committed $how_many
Tags $last_tag_like_review_signoff_etc $how_many
Top reviewers: // Top 3 reviewers (who are not listed in MAINTAINERS)
[$count_of_reviews_and_acks]: $email
INACTIVE MAINTAINER $name // maintainer / reviewer who has done nothing in last 5yrs
Jakub Kicinski (9):
MAINTAINERS: altx: move Jay Cliburn to CREDITS
MAINTAINERS: net: move Alexey Kuznetsov to CREDITS
MAINTAINERS: vrf: move Shrijeet to CREDITS
MAINTAINERS: ena: remove Zorik Machulsky from reviewers
MAINTAINERS: tls: move Aviad to CREDITS
MAINTAINERS: mtk-eth: remove Felix
MAINTAINERS: ipvs: move Wensong Zhang to CREDITS
MAINTAINERS: dccp: move Gerrit Renker to CREDITS
MAINTAINERS: skge/sky2: move Mirko Lindner to CREDITS
CREDITS | 28 ++++++++++++++++++++++++++++
MAINTAINERS | 11 +----------
2 files changed, 29 insertions(+), 10 deletions(-)
--
2.26.2
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-01-11 05:29:00
Jay was not active in recent years and does not have plans
to return to work on ATLX drivers.
Subsystem ATLX ETHERNET DRIVERS
Changes 20 / 116 (17%)
Last activity: 2020-02-24
Jay Cliburn [off-list ref]:
Chris Snook [off-list ref]:
Tags ea973742140b 2020-02-24 00:00:00 1
Top reviewers:
[4]: andrew@lunn.ch
[2]: kuba@kernel.org
[2]: o.rempel@pengutronix.de
INACTIVE MAINTAINER Jay Cliburn [off-list ref]
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Jay Cliburn <redacted>
CC: Chris Snook <chris.snook@gmail.com>
---
CREDITS | 4 ++++
MAINTAINERS | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
@@ -2142,6 +2142,10 @@ E: seasons@falcon.sch.bme.hu E: seasons@makosteszta.sote.hu D: Original author of software suspend+N: Alexey Kuznetsov+E: kuznet@ms2.inr.ac.ru+D: Author and maintainer of large parts of the networking stack+ N: Jaroslav Kysela E: perex@perex.cz W: https://www.perex.cz
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-01-11 05:29:25
As far as I can tell we haven't heard from Gerrit for roughly
5 years now. DCCP patch would really benefit from some review.
Gerrit was the last maintainer so mark this entry as orphaned.
Subsystem DCCP PROTOCOL
Changes 38 / 166 (22%)
(No activity)
Top reviewers:
[6]: kstewart@linuxfoundation.org
[6]: allison@lohutok.net
[5]: edumazet@google.com
INACTIVE MAINTAINER Gerrit Renker [off-list ref]
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Gerrit Renker <redacted>
CC: dccp@vger.kernel.org
---
CREDITS | 4 ++++
MAINTAINERS | 3 +--
2 files changed, 5 insertions(+), 2 deletions(-)
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-01-11 05:29:26
Drop Felix from Mediatek Ethernet driver maintainers.
We haven't seen any tags since the initial submission.
Not adding a CREDITS entry because summarizing Felix's
contributions as "initial Mediatek MT7623 driver" is
really selling it short. And Felix is not gone, so he
can write his own description :P
Subsystem MEDIATEK ETHERNET DRIVER
Changes 39 / 196 (19%)
Last activity: 2020-04-07
Felix Fietkau [off-list ref]:
John Crispin [off-list ref]:
Author 6427dc1da51d 2017-08-09 00:00:00 28
Tags 6427dc1da51d 2017-08-09 00:00:00 38
Sean Wang [off-list ref]:
Author 880c2d4b2fdf 2019-06-03 00:00:00 50
Tags a5d75538295b 2020-04-07 00:00:00 55
Mark Lee [off-list ref]:
Author 8d66a8183d0c 2019-11-14 00:00:00 4
Tags 8d66a8183d0c 2019-11-14 00:00:00 4
Top reviewers:
[8]: andrew@lunn.ch
[7]: f.fainelli@gmail.com
INACTIVE MAINTAINER Felix Fietkau [off-list ref]
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Felix Fietkau <nbd@nbd.name>
CC: John Crispin <john@phrozen.org>
CC: Sean Wang <sean.wang@mediatek.com>
CC: Mark Lee <redacted>
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
@@ -11165,7 +11165,6 @@ F: Documentation/devicetree/bindings/dma/mtk-* F: drivers/dma/mediatek/ MEDIATEK ETHERNET DRIVER-M: Felix Fietkau <nbd@nbd.name> M: John Crispin <john@phrozen.org> M: Sean Wang <sean.wang@mediatek.com> M: Mark Lee <Mark-MC.Lee@mediatek.com>
@@ -2262,6 +2262,10 @@ D: and much more. He was the maintainer of MD from 2016 to 2018. Shaohua D: passed away late 2018, he will be greatly missed. W: https://www.spinics.net/lists/raid/msg61993.html+N: Mirko Lindner+E: mlindner@marvell.com+D: Marvell Gigabit Ethernet drivers (skge/sky2).+ N: Stephan Linz E: linz@mazet.de E: Stephan.Linz@gmx.de
From: Chris Snook <chris.snook@gmail.com> Date: 2021-01-11 05:37:34
On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski [off-list ref] wrote:
Jay was not active in recent years and does not have plans
to return to work on ATLX drivers.
Subsystem ATLX ETHERNET DRIVERS
Changes 20 / 116 (17%)
Last activity: 2020-02-24
Jay Cliburn [off-list ref]:
Chris Snook [off-list ref]:
Tags ea973742140b 2020-02-24 00:00:00 1
Top reviewers:
[4]: andrew@lunn.ch
[2]: kuba@kernel.org
[2]: o.rempel@pengutronix.de
INACTIVE MAINTAINER Jay Cliburn [off-list ref]
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Jay Cliburn <redacted>
CC: Chris Snook <chris.snook@gmail.com>
---
I'm overdue to be moved to CREDITS as well. I never had alx hardware,
I no longer have atl1c or atl1e hardware, and I haven't powered on my
atl1 or atl2 hardware in years.
- Chris
F: drivers/dma/mediatek/
MEDIATEK ETHERNET DRIVER
-M: Felix Fietkau [off-list ref]
M: John Crispin [off-list ref]
M: Sean Wang [off-list ref]
M: Mark Lee [off-list ref]
I think your script is broken as there are multiple subdirectories
for this entry and Felix is active.
For instance:
commit 9716ef046b46a6426b2a11301ea5232fc8cdce63
Author: Felix Fietkau [off-list ref]
Date: Sat Nov 21 18:23:35 2020 +0100
mt76: attempt to free up more room when filling the tx queue
Run dma cleanup immediately if the queue is almost full, instead of waiting
for the tx interrupt
Signed-off-by: Felix Fietkau [off-list ref]
F: drivers/dma/mediatek/
MEDIATEK ETHERNET DRIVER
-M: Felix Fietkau [off-list ref]
M: John Crispin [off-list ref]
M: Sean Wang [off-list ref]
M: Mark Lee [off-list ref]
I think your script is broken as there are multiple subdirectories
for this entry and
Quite the opposite, the script intentionally only counts contributions
only to the code under the MAINTAINERS entry. People lose interest and
move on to working on other parts of the kernel (or maybe were never
that interested in maintaining something in the first place?).
We want to list folks who are likely to give us reviews.
Felix is active.
Which I tried to state in the commit message as well :)
F: drivers/dma/mediatek/
MEDIATEK ETHERNET DRIVER
-M: Felix Fietkau [off-list ref]
M: John Crispin [off-list ref]
M: Sean Wang [off-list ref]
M: Mark Lee [off-list ref]
I think your script is broken as there are multiple subdirectories
for this entry and
Quite the opposite, the script intentionally only counts contributions
only to the code under the MAINTAINERS entry. People lose interest and
move on to working on other parts of the kernel (or maybe were never
that interested in maintaining something in the first place?).
We want to list folks who are likely to give us reviews.
quoted
Felix is active.
Which I tried to state in the commit message as well :)
Sorry for the delayed response. I'm going to submit a bunch of work on
this driver in the near future.
The patches have already been written, just need a bit more time for
testing/review.
- Felix
F: drivers/dma/mediatek/
MEDIATEK ETHERNET DRIVER
-M: Felix Fietkau [off-list ref]
M: John Crispin [off-list ref]
M: Sean Wang [off-list ref]
M: Mark Lee [off-list ref]
I think your script is broken as there are multiple subdirectories
for this entry and
Quite the opposite, the script intentionally only counts contributions
only to the code under the MAINTAINERS entry.
My mistake. I'd seen Felix's name fairly often.
I ran this command:
$ git log --pretty=oneline --since=5-years-ago --grep="-by: Felix Fietkau" drivers/net/ethernet/mediatek/
656e705243fd0c2864b89634ea16ed444ef64dc6 net-next: mediatek: add support for MT7623 ethernet
Saw that felix had worked on mediatek and then looked up files in
drivers/net with mediatek and conflated the wireless files and ethernet files.
btw: because I didn't see the script published and so can't verify what's
being done here, the MAINTAINERS file shows:
F: *Files* and directories wildcard patterns.
A trailing slash includes all files and subdirectory files.
F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below
cheers, Joe
F: drivers/dma/mediatek/
MEDIATEK ETHERNET DRIVER
-M: Felix Fietkau [off-list ref]
M: John Crispin [off-list ref]
M: Sean Wang [off-list ref]
M: Mark Lee [off-list ref]
I think your script is broken as there are multiple subdirectories
for this entry and
Quite the opposite, the script intentionally only counts contributions
only to the code under the MAINTAINERS entry. People lose interest and
move on to working on other parts of the kernel (or maybe were never
that interested in maintaining something in the first place?).
We want to list folks who are likely to give us reviews.
quoted
Felix is active.
Which I tried to state in the commit message as well :)
Sorry for the delayed response. I'm going to submit a bunch of work on
this driver in the near future.
The patches have already been written, just need a bit more time for
testing/review.
Great, I'll drop this patch from the series.
Thanks!
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-01-12 02:40:02
On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote:
On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski [off-list ref] wrote:
quoted
Jay was not active in recent years and does not have plans
to return to work on ATLX drivers.
Subsystem ATLX ETHERNET DRIVERS
Changes 20 / 116 (17%)
Last activity: 2020-02-24
Jay Cliburn [off-list ref]:
Chris Snook [off-list ref]:
Tags ea973742140b 2020-02-24 00:00:00 1
Top reviewers:
[4]: andrew@lunn.ch
[2]: kuba@kernel.org
[2]: o.rempel@pengutronix.de
INACTIVE MAINTAINER Jay Cliburn [off-list ref]
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
I'm overdue to be moved to CREDITS as well. I never had alx hardware,
I no longer have atl1c or atl1e hardware, and I haven't powered on my
atl1 or atl2 hardware in years.
Your call, obviously, but having someone familiar with the code and the
hardware look at the patches and provide Ack or Review tags is in
itself very, very helpful. There is no requirement to actually test any
of the changes or develop new features.
From: Chris Snook <chris.snook@gmail.com> Date: 2021-01-12 03:32:59
On Mon, Jan 11, 2021 at 6:39 PM Jakub Kicinski [off-list ref] wrote:
On Sun, 10 Jan 2021 21:36:24 -0800 Chris Snook wrote:
quoted
On Sun, Jan 10, 2021 at 9:28 PM Jakub Kicinski [off-list ref] wrote:
quoted
Jay was not active in recent years and does not have plans
to return to work on ATLX drivers.
Subsystem ATLX ETHERNET DRIVERS
Changes 20 / 116 (17%)
Last activity: 2020-02-24
Jay Cliburn [off-list ref]:
Chris Snook [off-list ref]:
Tags ea973742140b 2020-02-24 00:00:00 1
Top reviewers:
[4]: andrew@lunn.ch
[2]: kuba@kernel.org
[2]: o.rempel@pengutronix.de
INACTIVE MAINTAINER Jay Cliburn [off-list ref]
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
I'm overdue to be moved to CREDITS as well. I never had alx hardware,
I no longer have atl1c or atl1e hardware, and I haven't powered on my
atl1 or atl2 hardware in years.
Your call, obviously, but having someone familiar with the code and the
hardware look at the patches and provide Ack or Review tags is in
itself very, very helpful. There is no requirement to actually test any
of the changes or develop new features.
In that case, I'm happy to keep reviewing them.
Acked-by: Chris Snook <chris.snook@gmail.com>