Re: [PATCH v3 net-next 01/11] net: switchdev: remove vid_begin -> vid_end range from VLAN objects
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-01-07 10:11:32
On Thu, Jan 07, 2021 at 08:17:14AM +0100, Kurt Kanzenbach wrote:
[snip]quoted
--- a/drivers/net/dsa/hirschmann/hellcreek.c +++ b/drivers/net/dsa/hirschmann/hellcreek.c@@ -353,9 +353,8 @@ static int hellcreek_vlan_prepare(struct dsa_switch *ds, int port, if (!dsa_is_user_port(ds, i)) continue; - for (vid = vlan->vid_begin; vid <= vlan->vid_end; ++vid) - if (vid == restricted_vid) - return -EBUSY; + if (vlan->vid == restricted_vid) + return -EBUSY;`u16 vid' is not used anymore: drivers/net/dsa/hirschmann/hellcreek.c: In function ‘hellcreek_vlan_prepare’: drivers/net/dsa/hirschmann/hellcreek.c:359:7: warning: unused variable ‘vid’ [-Wunused-variable] u16 vid; ^~~
Thanks, I noticed now. I also noticed I did not update dsa_loop. Sorry. https://patchwork.hopto.org/static/nipa/410259/12002471/build_32bit/stderr