Thread (74 messages) 74 messages, 18 authors, 2021-01-11

Re: [patch 22/30] net/mlx5: Replace irq_to_desc() abuse

From: Tariq Toukan <hidden>
Date: 2020-12-13 11:35:02
Also in: dri-devel, intel-gfx, linux-gpio, linux-pci, linux-rdma, linux-s390, lkml, xen-devel


On 12/10/2020 9:25 PM, Thomas Gleixner wrote:
No driver has any business with the internals of an interrupt
descriptor. Storing a pointer to it just to use yet another helper at the
actual usage site to retrieve the affinity mask is creative at best. Just
because C does not allow encapsulation does not mean that the kernel has no
limits.

Retrieve a pointer to the affinity mask itself and use that. It's still
using an interface which is usually not for random drivers, but definitely
less hideous than the previous hack.

Signed-off-by: Thomas Gleixner <redacted>
---
  drivers/net/ethernet/mellanox/mlx5/core/en.h      |    2 +-
  drivers/net/ethernet/mellanox/mlx5/core/en_main.c |    2 +-
  drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c |    6 +-----
  3 files changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help