Re: [PATCH 1/1] net: Fix use of proc_fs
From: Arnd Bergmann <arnd@kernel.org>
Date: 2020-12-11 21:48:55
Also in:
bpf, lkml
On Fri, Dec 11, 2020 at 5:37 PM Yonatan Linik [off-list ref] wrote:
quoted hunk ↗ jump to hunk
index 2b33e977a905..031f2b593720 100644--- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c@@ -4612,9 +4612,11 @@ static int __net_init packet_net_init(struct net *net) mutex_init(&net->packet.sklist_lock); INIT_HLIST_HEAD(&net->packet.sklist); +#ifdef CONFIG_PROC_FS if (!proc_create_net("packet", 0, net->proc_net, &packet_seq_ops, sizeof(struct seq_net_private))) return -ENOMEM; +#endif /* CONFIG_PROC_FS */
Another option would be to just ignore the return code here
and continue without a procfs file, regardless of whether procfs
is enabled or not.
Arnd