On Thursday, 3 December 2020, 15:12:55 CET, Richard Cochran wrote:

On Thu, Dec 03, 2020 at 11:21:17AM +0100, Christian Eggers wrote:

quoted

The KSZ9563 has a Trigger Output Unit (TOU) which can be used to
generate periodic signals.

The pulse length can be altered via a device attribute.

Device tree is the wrong place for that.

I meant a device specfic sysfs attribute.
/sys/class/ptp/ptp2/device/pulse

But this is not true anymore, as I moved the sysfs attribute to a later 
patch (not submitted yet).

Aren't you using PTP_PEROUT_DUTY_CYCLE anyhow?

I also use PTP_PEROUT_DUTY_CYCLE. But this cannot be set via a shell
script. The existing "period" sysfs attribute doesn't allow to set
the pulse length, so I added a device specific attribute for this.

Should ptp_sysfs be extended with a "pulse" attribute with calls
enable() with only PTP_PEROUT_DUTY_CYCLE set?

Thanks,
Richard

regards
Christian