On Wed, Dec 16, 2020 at 20:02, Vladimir Oltean [off-list ref] wrote:

On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote:

quoted

+	/* Drivers that benefit from having an ID associated with each
+	 * offloaded LAG should set this to the maximum number of
+	 * supported IDs. DSA will then maintain a mapping of _at
+	 * least_ these many IDs, accessible to drivers via
+	 * dsa_tree_lag_id().

           ~~~~~~~~~~~~~~~
           you named it dsa_lag_id() in the end.

quoted

+	 */
+	unsigned int		num_lag_ids;

[...]

quoted

+	/* No IDs left, which is OK. Some drivers do not need it. The
+	 * ones that do, e.g. mv88e6xxx, will discover that
+	 * dsa_tree_lag_id returns an error for this device when

           ~~~~~~~~~~~~~~~
           same thing here.

quoted

+	 * joining the LAG. The driver can then return -EOPNOTSUPP
+	 * back to DSA, which will fall back to a software LAG.
+	 */

Right, will fix!