Thread (15 messages) 15 messages, 5 authors, 2021-02-01

Re: [PATCH v5 3/6] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct

From: David Miller <davem@davemloft.net>
Date: 2020-12-07 15:02:08

From: Michael Grzeschik <redacted>
Date: Mon,  7 Dec 2020 13:56:24 +0100
quoted hunk ↗ jump to hunk
@@ -991,13 +1090,16 @@ static void ksz8_port_setup(struct ksz_device *dev, int port, bool cpu_port)
 static void ksz8_config_cpu_port(struct dsa_switch *ds)
 {
 	struct ksz_device *dev = ds->priv;
+	struct ksz8 *ksz8 = dev->priv;
+	const u8 *regs = ksz8->regs;
+	const u32 *masks = ksz8->masks;
 	struct ksz_port *p;
 	u8 remote;
 	int i;
 
Please use reverse christmas tree ordering for local variables.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help