Thread (13 messages) 13 messages, 6 authors, 2020-12-10

Re: [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void

From: Geoff Levand <geoff@infradead.org>
Date: 2020-11-28 22:12:58
Also in: alsa-devel, linux-block, linux-fbdev, linux-scsi, linux-usb, linuxppc-dev

On 11/26/20 8:59 AM, Uwe Kleine-König wrote:
The driver core ignores the return value of struct device_driver::remove
because there is only little that can be done. For the shutdown callback
it's ps3_system_bus_shutdown() which ignores the return value.

To simplify the quest to make struct device_driver::remove return void,
let struct ps3_system_bus_driver::remove return void, too. All users
already unconditionally return 0, this commit makes it obvious that
returning an error code is a bad idea and ensures future users behave
accordingly.

Signed-off-by: Uwe Kleine-König <redacted>
Seems OK with v5.9 on PS3.

Tested by: Geoff Levand [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help