Thread (13 messages) 13 messages, 6 authors, 2020-12-10

[PATCH 1/2] ALSA: ppc: drop if block with always false condition

flat view
STALE2144d LANDED

From: Uwe Kleine-König <hidden>
Date: 2020-11-26 17:01:52
Also in: alsa-devel, dri-devel, linux-block, linux-fbdev, linux-scsi, linux-usb, linuxppc-dev
Subsystem: ps3 platform support, sound, the rest · Maintainers: Geoff Levand, Jaroslav Kysela, Takashi Iwai, Linus Torvalds

Landed in mainline as 5c7797022fe9 on 2020-11-28.

The remove callback is only called for devices that were probed
successfully before. As the matching probe function cannot complete
without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to
check this here.

Signed-off-by: Uwe Kleine-König <redacted>
---
 sound/ppc/snd_ps3.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c
index 58bb49fff184..6ab796a5d936 100644
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -1053,8 +1053,6 @@ static int snd_ps3_driver_remove(struct ps3_system_bus_device *dev)
 {
 	int ret;
 	pr_info("%s:start id=%d\n", __func__,  dev->match_id);
-	if (dev->match_id != PS3_MATCH_ID_SOUND)
-		return -ENXIO;
 
 	/*
 	 * ctl and preallocate buffer will be freed in
-- 
2.29.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help