RE: [PATCH] libbpf: Remove unnecessary conversion to bool

From: Joe Perches

Sent: 06 November 2020 21:50

On Fri, 2020-11-06 at 13:32 -0800, Andrii Nakryiko wrote:

quoted

On Thu, Nov 5, 2020 at 11:12 PM [off-list ref] wrote:

quoted

Fix following warning from coccinelle:
./tools/lib/bpf/libbpf.c:1478:43-48: WARNING: conversion to bool not needed here

[]

quoted

quoted

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c

[]

quoted

quoted

@@ -1475,7 +1475,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val,

                                ext->name, value);
                        return -EINVAL;
                }
-               *(bool *)ext_val = value == 'y' ? true : false;
+               *(bool *)ext_val = value == 'y';

I actually did this intentionally. x = y == z; pattern looked too
obscure to my taste, tbh.

It's certainly a question of taste and obviously there is nothing
wrong with yours.

Maybe adding parentheses makes the below look less obscure to you?

	x = (y == z);

That just leads to people thinking conditionals need to be in parentheses
and then getting the priorities for ?: all wrong as in:
	x = a + (b == c) ? d : e;

It would (probably) be better to make 'ext_val' be a union type
(probably a 'pointer to a union' rather than a union of pointers)
so that all the casts go away.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)