Thread (5 messages) flat view 5 messages, 4 authors, 2020-11-07

Re: [PATCH] libbpf: Remove unnecessary conversion to bool

From: Andrii Nakryiko <hidden>
Date: 2020-11-06 21:32:56
Also in: bpf, lkml

On Thu, Nov 5, 2020 at 11:12 PM [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Kaixu Xia <redacted>

Fix following warning from coccinelle:

./tools/lib/bpf/libbpf.c:1478:43-48: WARNING: conversion to bool not needed here

Signed-off-by: Kaixu Xia <redacted>
---
 tools/lib/bpf/libbpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 313034117070..fb9625077983 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -1475,7 +1475,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val,
                                ext->name, value);
                        return -EINVAL;
                }
-               *(bool *)ext_val = value == 'y' ? true : false;
+               *(bool *)ext_val = value == 'y';
I actually did this intentionally. x = y == z; pattern looked too
obscure to my taste, tbh.
                break;
        case KCFG_TRISTATE:
                if (value == 'y')
--
2.20.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help