Re: [PATCH] dpaa2-eth: Fix compile error due to missing devlink support

From
Ioana Ciornei <ioana.ciornei@nxp.com>
Date
2020-11-23 15:15:58
Reply to
Ezequiel Garcia, 2020-11-23
On Mon, Nov 23, 2020 at 12:06:14PM -0300, Ezequiel Garcia wrote:
Hi Ioana,

On Mon, 2020-11-23 at 09:39 +0000, Ioana Ciornei wrote:
quoted
Hi Ezequiel,

Thanks a lot for the fix, I overlooked this when adding devlink support.
No worries :)
quoted
On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote:
quoted
The dpaa2 driver depends on devlink, so it should select
NET_DEVLINK in order to fix compile errors, such as:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report'
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get':
dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'
What tree is this intended for?
Oops, I forgot about netdev rules. I guess I haven't sent
a net patch in a long time.

This patch is a fix, so I guess it's for the 'net' tree.
 
quoted
Maybe add a fixes tag and send this towards the net tree?
Would you mind too much taking care of this, putting the
Fixes you think matches best?

That would be really appreciated!
Sure, I'll respin this.

Ioana
Thread (4 messages) 4 messages, 2 authors, last reply 2020-11-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help