Re: [PATCH] dpaa2-eth: Fix compile error due to missing devlink support

From
Ioana Ciornei <ioana.ciornei@nxp.com>
Date
2020-11-23 09:39:35
Reply to
Ezequiel Garcia, 2020-11-22
Hi Ezequiel,

Thanks a lot for the fix, I overlooked this when adding devlink support.

On Sat, Nov 21, 2020 at 09:23:36PM -0300, Ezequiel Garcia wrote:
The dpaa2 driver depends on devlink, so it should select
NET_DEVLINK in order to fix compile errors, such as:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report'
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get':
dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'
What tree is this intended for?

Maybe add a fixes tag and send this towards the net tree?

Ioana
quoted hunk ↗ jump to hunk
Signed-off-by: Ezequiel Garcia <redacted>
---
 drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
index cfd369cf4c8c..aee59ead7250 100644
--- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
@@ -2,6 +2,7 @@
 config FSL_DPAA2_ETH
      tristate "Freescale DPAA2 Ethernet"
      depends on FSL_MC_BUS && FSL_MC_DPIO
+     select NET_DEVLINK
      select PHYLINK
      select PCS_LYNX
      help
--
2.27.0
Thread (4 messages) 4 messages, 2 authors, last reply 2020-11-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help