Re: [PATCH net-next v4 4/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: 2020-10-30 21:28:54
Also in:
lkml
On Fri, Oct 30, 2020 at 4:08 PM Xie He [off-list ref] wrote:
On Fri, Oct 30, 2020 at 9:30 AM Willem de Bruijn [off-list ref] wrote:quoted
Acked-by: Willem de Bruijn <willemb@google.com>Thanks for your ack!quoted
Should this go to net if a bugfix though?Yes, this should theoretically be a bug fix. But I didn't think this was an important fix, because af_packet.c already had workarounds for this issue for all drivers that didn't have header_ops. We can separate this patch to make it go to "net" though, but I'm afraid that this will cause merging conflicts between "net" and "net-next".
Yes, it might require holding off the other patches until net is merged into net-next. Packet sockets are likely not the only way these packets are received? It changes mac_len as computed in __netif_receive_skb_core. If there is no real bug that is fixed, net-next is fine.