Re: [PATCH net-next 01/11] atm: horizon: shut up clang null pointer arithmetic warning
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-10-28 22:19:53
Also in:
lkml
From: Jakub Kicinski <kuba@kernel.org>
Date: 2020-10-28 22:19:53
Also in:
lkml
On Mon, 26 Oct 2020 22:29:48 +0100 Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>
Building a "W=1" kernel with clang produces a warning about
suspicous pointer arithmetic:
drivers/atm/horizon.c:1844:52: warning: performing pointer arithmetic
on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
for (mem = (HDW *) memmap; mem < (HDW *) (memmap + 1); ++mem)
The way that the addresses are handled is very obscure, and
rewriting it to be more conventional seems fairly pointless, given
that this driver probably has no users.
Shut up this warning by adding a cast to uintptr_t.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Hi! I'm not sure what your plan is for re-spinning but when you do could you please split the wireless changes out? Also we never got patch 3 IDK if that's a coincidence or if it wasn't for networking...